jspecify and java update#10
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I would release Also the |
ok.. so we stay on RC for now. just take a look it you think this and the usage are OK the way they are now |
ThoSap
left a comment
ThoSap
left a comment
There was a problem hiding this comment.
I don't remember if our Checkstyle config allows this, but I would name all it.aboutbits.checkstyle.Jspecify* classes JSpecify.
Otherwise LGTM 👍🏼
| <java.version>25</java.version> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <checkstyle.version>13.4.2</checkstyle.version> | ||
| <junit.version>6.0.3</junit.version> |
There was a problem hiding this comment.
https://docs.junit.org/6.1.0/release-notes.html
| <junit.version>6.0.3</junit.version> | |
| <junit.version>6.1.0</junit.version> |
| <checkstyle.version>13.4.2</checkstyle.version> | ||
| <junit.version>6.0.3</junit.version> | ||
| <errorprone.version>2.49.0</errorprone.version> | ||
| <nullaway.version>0.13.2</nullaway.version> |
There was a problem hiding this comment.
| <nullaway.version>0.13.2</nullaway.version> | |
| <nullaway.version>0.13.4</nullaway.version> |
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; |
There was a problem hiding this comment.
I've seen multiple files using the JUnit assertions instead of AssertJ.
The AssertJ lib is not yet included in the pom.xml.
There was a problem hiding this comment.
This will not work in our main project as with the DbMessageSource by default we can't use params, except when we specially handle it in the CustomGlobalExceptionHandler.
There was a problem hiding this comment.
Nevermind, in the test ArchitectureTest test context Spring Boot is not present (I think), so MessageSource is not relevant here.
3 participants
target: 2.0.0 (final)
known: readme is still out dated. won't fix now. this is built for our gradle integration
with usage example here: https://github.com/aboutbits/finstral-composer-api/pull/676